[Openmp-commits] [PATCH] D62199: [OPENMP][NVPTX]Fix barriers and parallel level counters, NFC.

Wed May 22 13:45:15 PDT 2019

arsenm added a comment.

In D62199#1512638 <https://reviews.llvm.org/D62199#1512638>, @ABataev wrote:

> 1. Because it is impossible to test them, that why it is NFC.

This doesn't make it NFC. There is intended change in behavior.

> 2. Yes, this is true. Bu the changes are rather small.

This isn't a reason to merge unrelated patches

> 3. It is only your opinion.

I agree with this issue. This is very hand wavy. If you cannot describe what the undefined behavior or problem is is, you can't come up with a sensible solution. As presented here, this does not justify why this fixes or works around the issue.

> 4. Again, this is your problem, The patch was approved bythe code owner

Patches can still be subject to post-commit reviews

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62199/new/

https://reviews.llvm.org/D62199