[Openmp-commits] [PATCH] D60223: [OpenMP][libomptarget] Enable requires flags for target libraries.

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In D60223#1510738 <https://reviews.llvm.org/D60223#1510738>, @Hahnfeld wrote:

> LG in case we don't need `__tgt_register_requires` to return a code in the near future (like for saying "that's not supported")


Sorry, mixed this up with `__tgt_rtl_init_requires` which is now gone. LGTM without restrictions :)



================
Comment at: libomptarget/src/rtl.h:125-126
 
   // Register a shared library with all (compatible) RTLs.
+  void RegisterRequires(int64_t flags);
+
----------------
Nit: This shouldn't be a copy of the comment for `RegisterLib`


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60223/new/

https://reviews.llvm.org/D60223