[Openmp-commits] [PATCH] D60223: [OpenMP][libomptarget] Enable requires flags for target libraries.

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea added a comment.

In D60223#1507576 <https://reviews.llvm.org/D60223#1507576>, @Hahnfeld wrote:

> In this patch `__tgt_rtl_init_requires` does nothing. Do we really want to add the prototype now? If yes, are we sure that we won't need to pass more information in the future? Once we add it, the runtime library must maintain compatibility.
>
> Moreover, I'm not sure if we should require plugins to implement the function if they don't need any addition checks. I'd propose to make this optional, ie look for the symbol via `dlsym` and disable the call if it's not found.


Should be optional now.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60223/new/

https://reviews.llvm.org/D60223