[Openmp-commits] [PATCH] D61603: [OpenMP] Fix gfortran bugzilla build bug 41755

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: runtime/src/CMakeLists.txt:242-244
+  if ("${CMAKE_Fortran_COMPILER_ID}" STREQUAL "GNU")
+    set(ADDITIONAL_Fortran_FLAGS "-fno-range-check")
+  endif()
----------------
I think this should be `CMAKE_Fortran_COMPILER_ID STREQUAL "GNU"` if I finally understood variable expansion in its full glory from what we discussed in many other revisions. (Yeah, many places are still wrong, but we can start by not making it worse.)

Do we need a configure check that this flag is indeed available? Just thinking, but it seems that GCC has this flag since ages, even in 4.8.5. So maybe that's just unnecessary work.

In any case, please add a comment explaining that this is to workaround a bug in GCC (if I read the bug and @AndreyChurbanov's explanation correctly).


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61603/new/

https://reviews.llvm.org/D61603