[Openmp-commits] [PATCH] D61523: [OPENMP][NVPTX]Improve number of threads counter, NFC.

[George Rokos via Phabricator via Openmp-commits]

grokos accepted this revision.
grokos added a comment.
This revision is now accepted and ready to land.

Looks good.



================
Comment at: libomptarget/deviceRTLs/nvptx/src/libcall.cu:33-34
 EXTERN void omp_set_num_threads(int num) {
-  // Ignore it for SPMD mode.
-  if (isSPMDMode())
+  // Ignore it for parallel region, other parallel regions can have only 1
+  // thread maximum.
+  if (parallelLevel[GetWarpId()] > 0)
----------------
Can you make this comment clearer? What is the first parallel region and what are the other parallel regions? I suppose you mean L1 parallel vs nested?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61523/new/

https://reviews.llvm.org/D61523