[Openmp-commits] [PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

Aaron Ballman via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Mar 22 12:18:26 PDT 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from a minor diagnostic wording nit.



================
Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:52
+                                         Clause->getDefaultKind());
+    diag(Clause->getBeginLoc(), "existing 'default' clause is specified here",
+         DiagnosticIDs::Note);
----------------
drop the "is" to make it match how we usually phrase things.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57113/new/

https://reviews.llvm.org/D57113





More information about the Openmp-commits mailing list