[Openmp-commits] [PATCH] D59451: Fix gettid warnings and one test on FreeBSD

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a subscriber: EricWF.
Hahnfeld added a comment.

In D59451#1432390 <https://reviews.llvm.org/D59451#1432390>, @Hahnfeld wrote:

> In D59451#1432389 <https://reviews.llvm.org/D59451#1432389>, @krytarowski wrote:
>
> > I'm not sure about OMP specifics, but in C++ threads we are allowed to use threading routines but in order to make them functional we must link final executable with `libpthread`.
> >
> > On NetBSD threading is in a separate library out of libc.
>
>
> So if a developer uses a feature from stdlib, they need to manually link libpthread? I always thought that the C++ standard guarantees you a fully working stdlib out of the box, but might be wrong here.


Hmm, looks like this used to be true (for example with libstdc++ from GCC 4.8 found in CentOS 7), but it's not with libc++ and newer libstdc++. @EricWF looks like this is expected if both libc++ and (newer) libstdc++ agree?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59451/new/

https://reviews.llvm.org/D59451