[Openmp-commits] [PATCH] D59451: Fix gettid warnings and one test on FreeBSD

Sat Mar 16 05:38:16 PDT 2019

dim added a comment.

In D59451#1431899 <https://reviews.llvm.org/D59451#1431899>, @krytarowski wrote:

> If we want to depend on pthread, please go for canonical `-pthread`.

Hm, I copied this from several other tests, which use the same construct, so I don't see why this one should be different.  (In fact pthread detection is a can of worms, many configure scripts go through extreme lengths to determine the exact magical incantation needed... but most of the time `-lpthread` works everywhere, except on Windows of course. :) )

> Is this test supported on !POSIX platforms like Windows?

I don't know how to check which tests are run for Windows, and which ones aren't.  Can you enlighten me?

There don't seem to be many Windows references in the openmp test suite, except for the file `runtime/test/omp_testsuite.h` which seems to implement a pthread wrapper for Windows.  But all tests which require pthreads are linked using either `%libomp-compile -lpthread` or `%libomp-cxx-compile -lpthread`, so that's why I copied that pattern.

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59451/new/

https://reviews.llvm.org/D59451