[Openmp-commits] [PATCH] D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov requested changes to this revision.
AndreyChurbanov added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: jdoerfert.


================
Comment at: runtime/src/kmp_os.h:605
+                                                __ATOMIC_SEQ_CST);
+  return *p;
+}
----------------
This looks wrong, because the function (or macro) should return the value of *p before the CAS operation, so it should return cv I think, which is either expected value of *p in case of success, or unexpected value read from *p in case CAS operation failed.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45691/new/

https://reviews.llvm.org/D45691