[Openmp-commits] [PATCH] D63196: Create a runtime option to disable task throttling

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

Yes, adding tests would be great. Simplest thing to do is to extend existing tests with throttling on/off, I think.

Philippe,
If you don't mind, could you please update the patch adding tests. I'd suggest to use two existing tests with big number of created tasks (all others use small number of tasks and thus are not relevant to this patch). Possible additional change is:

  Index: runtime/test/tasking/omp_taskloop_grainsize.c
  ===================================================================
  --- runtime/test/tasking/omp_taskloop_grainsize.c       (revision 364425)
  +++ runtime/test/tasking/omp_taskloop_grainsize.c       (working copy)
  @@ -1,5 +1,7 @@
   // RUN: %libomp-compile-and-run
   // RUN: %libomp-compile && env KMP_TASKLOOP_MIN_TASKS=1 %libomp-run
  +// RUN: %libomp-compile && env KMP_ENABLE_TASK_THROTTLING=0 %libomp-run
  +// RUN: %libomp-compile && env KMP_ENABLE_TASK_THROTTLING=1 %libomp-run
   // REQUIRES: openmp-4.5
  
   // These compilers don't support the taskloop construct
  Index: runtime/test/tasking/omp_taskloop_num_tasks.c
  ===================================================================
  --- runtime/test/tasking/omp_taskloop_num_tasks.c       (revision 364425)
  +++ runtime/test/tasking/omp_taskloop_num_tasks.c       (working copy)
  @@ -2,6 +2,8 @@
   // UNSUPPORTED: netbsd
   // RUN: %libomp-compile-and-run
   // RUN: %libomp-compile && env KMP_TASKLOOP_MIN_TASKS=1 %libomp-run
  +// RUN: %libomp-compile && env KMP_ENABLE_TASK_THROTTLING=0 %libomp-run
  +// RUN: %libomp-compile && env KMP_ENABLE_TASK_THROTTLING=1 %libomp-run
   // REQUIRES: openmp-4.5
  
   // These compilers don't support the taskloop construct


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63196/new/

https://reviews.llvm.org/D63196