[Openmp-commits] [PATCH] D62485: New implementation of OpenMP 5.0 detached tasks.

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added inline comments.


================
Comment at: runtime/test/tasking/kmp_detach_tasks_t3.c:21
+typedef long long kmp_int64;
+
+typedef struct ID {
----------------
protze.joachim wrote:
> Is there any reason not to include kmp.h for the definition of the structs? 
> 
> I know, other tests also define them locally. 
This is general position - make tests independent of the library sources.  Presence of the built <binaries + public headers> should be enough to run tests.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62485/new/

https://reviews.llvm.org/D62485