[Openmp-commits] [PATCH] D62485: New implementation of OpenMP 5.0 detached tasks.

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: runtime/test/tasking/kmp_detach_tasks_t1.c:73
+
+void mySleep(unsigned ms) { // sleep ms milliseconds
+#if defined(WIN32)
----------------
there is omp_my_sleep.h in runtime/tests/
please consider to use that instead


================
Comment at: runtime/test/tasking/kmp_detach_tasks_t3.c:21
+typedef long long kmp_int64;
+
+typedef struct ID {
----------------
Is there any reason not to include kmp.h for the definition of the structs? 

I know, other tests also define them locally. 


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62485/new/

https://reviews.llvm.org/D62485