[Openmp-commits] [PATCH] D63009: [OpenMP] Add target task alloc function with device ID

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In D63009#1544758 <https://reviews.llvm.org/D63009#1544758>, @Hahnfeld wrote:

> Am I correct that the second to last revision ("- Fix tests.") removed all checks for the actual `device_id` argument from the tests? From my point of view that's not fixing but weakening the tests! Can you explain why they needed "fixing"?
>
> If I had to guess this is because some directives have the `device` clause, so the tests should check that the generated code passes the correct argument in that case.


+1. Missed the test checks, tests must be fixed


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63009/new/

https://reviews.llvm.org/D63009