[Openmp-commits] [PATCH] D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In D62841#1530493 <https://reviews.llvm.org/D62841#1530493>, @twoh wrote:

> @Hahnfeld I'm not an OpenMP expert and don't have much strong argument here, but IMHO it might be confusing to have LLVM_ENABLE_FFI and LIBOMPTARGET_ENABLE_FFI have different default value from user's perspective. I wonder if we can set it off by default and explicitly turn it on for builds with test?


Tests are enabled by default, so we'd also need to enable libffi by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62841/new/

https://reviews.llvm.org/D62841