[Openmp-commits] [PATCH] D62488: Added propagation of not big initial stack size of master thread to workers.

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: runtime/src/kmp_settings.cpp:294
+void __kmp_check_stksize(size_t *val) {
+  if (*val < KMP_MIN_STKSIZE || *val >= KMP_MAX_STKSIZE) {
+    *val = KMP_DEFAULT_STKSIZE; // mimics old default behaviour
----------------
[My initial comment got somehow lost:( ]

I have the same problem with this logic as I had before. I would like us to saturate at the edges and not jump to an arbitrary default value suddenly.

Assuming I got the min/max right, I would like:

```
*val = min(KMP_MAX_STKSIZE, max(KMP_MIN_STKSIZE, *val));
```

If there is a problem with that, please describe it, preferably also in the code above.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62488/new/

https://reviews.llvm.org/D62488