[Openmp-commits] [PATCH] D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

May I propose something extra? I guess the purpose of this patch is to disable libffi, for instance on systems where the library is not installed or for whatever reason the user doesn't want to use it. In that case, we should accommodate for the standalone build as well. We could introduce a new Cmake variable `LIBOMPTARGET_ENABLE_FFI` and

- set it to `LLVM_ENABLE_FFI` if building in-tree or
- have a default value of true if building standalone and let the user set it to false if they want to

Any thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62841/new/

https://reviews.llvm.org/D62841