[Openmp-commits] [PATCH] D60972: [OpenMP 5.0] libomptarget interface for declare mapper functions

Tue Jun 4 05:33:50 PDT 2019

lildmh added a comment.

In D60972#1528662 <https://reviews.llvm.org/D60972#1528662>, @Hahnfeld wrote:

> In D60972#1528060 <https://reviews.llvm.org/D60972#1528060>, @lildmh wrote:
>
> > In D60972#1528023 <https://reviews.llvm.org/D60972#1528023>, @grokos wrote:
> >
> > > I think this patch is wrong. Where are the previous additions of `target_data` and `__tgt_target_data_mapper`? Possibly you uploaded the diff between the previous revision and the current one, whereas you need to upload the diff between origin/master and your current HEAD!
> >
> >
> > Please see the attachment of Ravi sent for the biweekly meeting to see details about this new scheme. Sorry I forgot to mention
>
>
> It would be great to have such things in public...

Sure, there is no secret. Please see it here if you are interested: https://github.com/lingda-li/public-sharing/blob/master/mapper_runtime_design.pptx

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60972/new/

https://reviews.llvm.org/D60972