[Openmp-commits] [PATCH] D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: libomptarget/plugins/exports:5
     __tgt_rtl_number_of_devices;
+    __tgt_rtl_init_requires;
     __tgt_rtl_init_device;
----------------
grokos wrote:
> One last question because I'm not very familiar with exporting symbols. If a plugin does not implement `__tgt_rtl_init_requires` (as is the case with generic-elf-64), will there be any problem with exporting the symbol?
Supporting that method is optional so the function will not get called in that case. In the next chunk of added code you can see that the call to the init_requires() function is guarded:


```
if (RTL->init_requires)
    RTL->init_requires(RTLRequiresFlags);
```


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60884/new/

https://reviews.llvm.org/D60884