[Openmp-commits] [PATCH] D55725: [OpenMP] Add libs to clang-dedicated directories

Fri Jan 25 10:09:41 PST 2019

hfinkel added a comment.

In D55725#1371526 <https://reviews.llvm.org/D55725#1371526>, @jdenny wrote:

> In D55725#1371505 <https://reviews.llvm.org/D55725#1371505>, @hfinkel wrote:
>
> > > Agreed, but it might be worthwhile to choose a guinea pig (openmp) first. I find it difficult to think of all the possible consequences of changes like this.
> >
> > I feel it's likely there are some things we're not considering, but as a result, the prudent thing to do is to propose the change for libc++ also. We'll, potentially, get a much-wider set of feedback and, based on that, be able to make a better-informed decision. That's the path I prefer that we take. I recommend that you write an RFC for cfe-dev proposing to apply this change to all runtime libraries (openmp, libc++, etc.). It might turn out that there are technical reasons why this would not work for some libraries and would work for others, but I think that we should understand what those reasons are before we proceed. Once we've collected this feedback, the ordering in which we try applying the change to specific projects can be determined. libomp can then be the guinea pig if that's the logical thing to do.
>
>
> Sounds reasonable.
>
> I'd like to bake this patch a little longer to apply some of the ideas we're discussing.  I'll then post the RFC and point here before working on patches for other runtimes.
>
> cfe-dev is sufficient for the RFC?

Thanks, and sounds good. Yes, cfe-dev should be sufficient (and cross-posting between dev lists is generally discouraged, except for announcements for which replies are not expected, because not everyone is subscribed to all lists).

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55725/new/

https://reviews.llvm.org/D55725