[Openmp-commits] [PATCH] D55725: [OpenMP] Add libs to clang-dedicated directories

Hal Finkel via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 24 17:39:17 PST 2019


hfinkel added a comment.

> libgomp.so, libiomp5.so: My understanding is that these symlinks exist solely for backward compatibility. This patch currently doesn't affect them (doesn't bother to install them to Clang-dedicated directories). Any reason to change that?

No, I see no reason to change that.

> lib/clang/9.0.0/lib/linux/x86_64 is what this patch currently chooses as it's another place Clang looks. But is that any better or worse than the next option?

So Clang always searches this directory but we never put anything there? I vaguely recall that this is where the compiler-rt libs used to be.

> Move libc++* and libunwind* from lib to the Clang-dedicated directory.

So we have the same problem with libc++ and friends as well? I'd prefer that whatever solution we come up with here can be uniformly applied across subprojects. Any reason of which you can think for why libc++ and libomp should have different behaviors in this regard?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55725/new/

https://reviews.llvm.org/D55725





More information about the Openmp-commits mailing list