[Openmp-commits] [PATCH] D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates

[Hansang Bae via Phabricator via Openmp-commits]

hbae added inline comments.


================
Comment at: runtime/src/include/50/omp-tools.h.var:2
+/*
+ * include/50/ompt.h.var
+ */
----------------
Change `ompt.h.var` to `omp-tools.h.var`


================
Comment at: runtime/src/kmp_csupport.cpp:514
           ompt_scope_end, NULL, OMPT_CUR_TASK_DATA(this_thr), 1,
-          OMPT_CUR_TASK_INFO(this_thr)->thread_num);
+          OMPT_CUR_TASK_INFO(this_thr)->thread_num, 0);
     }
----------------
`ompt_task_implicit` for the last argument.


================
Comment at: runtime/src/kmp_wait_release.h:143
         ompt_callbacks.ompt_callback(ompt_callback_implicit_task)(
-            ompt_scope_end, NULL, tId, 0, ds_tid);
+            ompt_scope_end, NULL, tId, 0, ds_tid, 0);
       }
----------------
`ompt_task_implicit` seems to be the right value for the last argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55579/new/

https://reviews.llvm.org/D55579