[Openmp-commits] [PATCH] D56432: Documentation: providing a more precise description of a parameter of the kmpc_taskloop function

[Sergi Mateo via Phabricator via Openmp-commits]

smateo created this revision.
smateo added reviewers: protze.joachim, AndreyChurbanov.
smateo added a project: OpenMP.
Herald added a subscriber: openmp-commits.

Some time ago I opened the following revision to fix an issue related to the implicit taskgroup associated with a taskloop construct that doesn't have the `nogroup` clause:

https://bugs.llvm.org/show_bug.cgi?id=37737
https://reviews.llvm.org/D53636

Those changes were upstreamed, but I forgot to update the documentation. This revision tries to address that.

In clang we explicitly materialize the implicit taskgroup when it is required. Thus, we always pass a `1` as the value of the nogroup parameter. Since this parameter doesn't represent whether the `nogroup` clause was present but whether we want to create a taskgroup region inside the kmpc_taskloop function, I think we should change its description.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D56432

Files:
  runtime/src/kmp_tasking.cpp


Index: runtime/src/kmp_tasking.cpp
===================================================================
--- runtime/src/kmp_tasking.cpp
+++ runtime/src/kmp_tasking.cpp
@@ -4132,7 +4132,7 @@
 @param lb        Pointer to loop lower bound in task structure
 @param ub        Pointer to loop upper bound in task structure
 @param st        Loop stride
- at param nogroup   Flag, 1 if nogroup clause specified, 0 otherwise
+ at param nogroup   Flag, 1 if no taskgroup needs to be added, 0 otherwise
 @param sched     Schedule specified 0/1/2 for none/grainsize/num_tasks
 @param grainsize Schedule value if specified
 @param task_dup  Tasks duplication routine


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56432.180637.patch
Type: text/x-patch
Size: 649 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20190108/2fc7cdea/attachment.bin>