[Openmp-commits] [PATCH] D56202: [OpenMP] Remove -fno-experimental-isel from OMP testing

David Greene via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jan 4 11:29:26 PST 2019


greened added a comment.

No, I haven't implemented ```frameaddress`` or done any GISel work at all.  From our ML conversation, I was under the impression that the tests didn't need ```-fno-experimental-isel``` anymore.

http://lists.llvm.org/pipermail/llvm-dev/2018-December/128697.html

Specifically, "I was the one who originally added the flag to fix failures related to  GlobalISel. This was because first versions of GlobalISel didn't know  how to select 'blockaddress', but this should have been fixed"

And indeed, this change gets almost all of the OMPT tests passing for me.

If more work needs to be done then I can just abandon this revision.  I don't have the cycles to hack on GISel at the moment.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56202/new/

https://reviews.llvm.org/D56202





More information about the Openmp-commits mailing list