[Openmp-commits] [PATCH] D56290: [OPENMP][NVPTX]General formatting/code improvement, NFC.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev marked 2 inline comments as done.
ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/loop.cu:420
   // in a warp cannot make independent progress.
-  NOINLINE static int dispatch_next(int32_t gtid, int32_t *plast, T *plower,
-                                    T *pupper, ST *pstride) {
+  INLINE static int dispatch_next(int32_t gtid, int32_t *plast, T *plower,
+                                  T *pupper, ST *pstride) {
----------------
grokos wrote:
> What about the Pascal issue when inlining this function?
Everything works with the inlined functions. Seems to me, the problem was caused again with the __syncthreads() problem. Just need to remove the comment.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/reduction.cu:197
 #else
-  uint32_t Liveness = __BALLOT_SYNC(0xFFFFFFFF, true);
+  uint32_t Liveness = __ACTIVEMASK();
   if (Liveness == 0xffffffff) // Full warp
----------------
grokos wrote:
> Can the rest of `__BALLOT_SYNC` instances in this file be replaced with `__ACTIVEMASK()`? If so, then we can remove the definition of `__BALLOT_SYNC` altogether from `omptarget-nvptx.h`.
Will try


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56290/new/

https://reviews.llvm.org/D56290