[Openmp-commits] [PATCH] D56278: [OPENMP][NVPTX]Improve performance + reduce number of used registers.

Alexey Bataev via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jan 4 08:14:01 PST 2019


ABataev marked an inline comment as done.
ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:557-562
+EXTERN void __kmpc_get_team_static_memory(int16_t isSPMDExecutionMode,
+                                          const void *buf, size_t size,
                                           int16_t is_shared, const void **res);
 
-EXTERN void __kmpc_restore_team_static_memory(int16_t is_shared);
+EXTERN void __kmpc_restore_team_static_memory(int16_t isSPMDExecutionMode,
+                                              int16_t is_shared);
----------------
grokos wrote:
> Don't these API functions need a `_v2` version for backwards compatibility just like `__kmpc_nvptx_parallel_reduce_nowait`?
No, those functions were not used in previous release versions, they were introduced only in current trunk version, so we can safely change them


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56278/new/

https://reviews.llvm.org/D56278





More information about the Openmp-commits mailing list