[Openmp-commits] [PATCH] D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end

[Hansang Bae via Phabricator via Openmp-commits]

hbae added inline comments.


================
Comment at: runtime/src/kmp_runtime.cpp:3992
+    ompt_callbacks.ompt_callback(ompt_callback_implicit_task)(
+        ompt_scope_end, parallel_data, task_data, 1, 1, ompt_task_initial);
+  }
----------------
I am not sure if this call corresponds to the 5.0 spec's description (472:26--29).

> The actual_parallelism argument indicates the number of threads in the parallel region or the number of teams in the teams region. For initial tasks, that are not closely nested in a teams construct, this argument is 1. For the implicit-task-end and the initial-task-end events, this argument is 0.





================
Comment at: runtime/test/ompt/callback.h:465
+        parallel_data->value = ompt_get_unique_id();
+        printf("%" PRIu64 ": ompt_event_task_create: parent_task_id=%" PRIu64 ", parent_task_frame.exit=%p, parent_task_frame.reenter=%p, new_task_id=%" PRIu64 ", codeptr_ra=%p, task_type=%s=%d, has_dependences=%s\n", ompt_get_thread_data()->value, 0 , NULL, NULL, task_data->value, NULL, buffer, flags, "no");
+      } else {
----------------
I think this statement should print information about `ompt_event_initial_task_begin`.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58776/new/

https://reviews.llvm.org/D58776