[Openmp-commits] [PATCH] D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures

Hans Wennborg via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 21 00:39:05 PST 2019


hans added inline comments.


================
Comment at: runtime/test/ompt/synchronization/lock.c:13
   omp_lock_t lock;
-  printf("%" PRIu64 ": &lock: %" PRIu64 "\n", ompt_get_thread_data()->value, (uint64_t) &lock);
+  printf("%" PRIu64 ": &lock: %" PRIu64 "\n", ompt_get_thread_data()->value, (ompt_wait_id_t) &lock);
   omp_init_lock(&lock);
----------------
I don't know this code at all obviously, but will this work with the PRIu64 conversion specifier? If ompt_wait_id_t is 32-bit on 32-bit platforms, this sounds like it wouldn't match?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58454/new/

https://reviews.llvm.org/D58454





More information about the Openmp-commits mailing list