[Openmp-commits] [PATCH] D56804: Fix thread_limits to work properly for teams construct

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

I'm a bit confused about the explicit copy per task.



================
Comment at: runtime/src/kmp.h:1851
                 thread) */
+  int thread_limit; /* internal control for thread-limit-var */
   int max_active_levels; /* internal control for max_active_levels */
----------------
Is this entry necessary? From my understanding of the spec, one copy per cg or thread should be sufficient.


================
Comment at: runtime/src/kmp_runtime.cpp:7280
+    // Store new thread limit; old limit is saved in th_cg_roots list
+    thr->th.th_current_task->td_icvs.thread_limit = num_threads;
+
----------------
If this is the reason for a per task icv, can't we reset the cg value to the initial value after leaving the teams region?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56804/new/

https://reviews.llvm.org/D56804