[Openmp-commits] [PATCH] D57848: [OPENMP] fix build failure with GCC4.8

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

As said in D57851 <https://reviews.llvm.org/D57851>, this will not handle Clang and only work for GCC.



================
Comment at: openmp/runtime/src/kmp_os.h:308
+#    define KMP_FALLTHROUGH() [[clang::fallthrough]]
+#  elif __has_attribute(fallthough) || __GNUC__ >= 7
+#    define KMP_FALLTHROUGH() __attribute__((__fallthrough__))
----------------
This change seems right, `_GNUC_VER` is not defined here!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57848/new/

https://reviews.llvm.org/D57848