[Openmp-commits] [PATCH] D71987: [OpenMP][NFC] Add a couple of TODOs to the runtime

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 30 09:36:49 PST 2019


jdoerfert marked an inline comment as done.
jdoerfert added a comment.

I'll look into how much work versioning for this type is, especially after we do not expose it to the frontends anymore.



================
Comment at: openmp/runtime/src/kmp.h:2122
 } kmp_task_t;
 
 /*!
----------------
JonChesterfield wrote:
> This does look strange.
> 
> Am I right in thinking that the two instances of the union are both used, one for the priority field and the other used for the destructors field? I haven't checked the corresponding codegen in clang.
That is basically how I understand this as well. None, one, or both can be used, depending if you have a priority and/or destructors. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71987/new/

https://reviews.llvm.org/D71987





More information about the Openmp-commits mailing list