[Openmp-commits] [PATCH] D71404: [libomptarget][nfc] Introduce atomic wrapper function

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 13 11:28:20 PST 2019


jdoerfert added a comment.

In D71404#1783828 <https://reviews.llvm.org/D71404#1783828>, @JonChesterfield wrote:

> That sounds pragmatic. A single header located under common/ will work for nvptx and amdgcn without #ifdef, so lets go with that. We can rearrange the code if necessary when a third target arises or when amdgcn/nvptx wants to implement the atomics differently.
>
> (amdgcn presently has a choice between clang builtins or one of the hip, opencl, hc libraries for the implementation)


Let's do that then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71404/new/

https://reviews.llvm.org/D71404





More information about the Openmp-commits mailing list