[Openmp-commits] [PATCH] D71446: [libomptarget] Build most of common/src for amdgcn

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

> Couldn't we provide these functions in the target_impl.h of amdgcn?

Indeed. That's the plan. Both have a degree of design choice about them though so were excluded from this patch.

> I would also rename the files to cpp as they seem to not contain CUDA anymore, correct?

They do not contain CUDA, other than the atomic functions which could be argued are just C++ anyway, as they appear in the amdgcn implementation. Renaming the files should be done separately to this though as it may upset the nvcc build (and definitely won't upset the amdgcn one).

How do you feel about landing this while I look into the other three points?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71446/new/

https://reviews.llvm.org/D71446