[Openmp-commits] [PATCH] D71404: [libomptarget][nfc] Introduce atomic wrapper function

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Dec 12 17:37:50 PST 2019


JonChesterfield added a comment.

In D71404#1782848 <https://reviews.llvm.org/D71404#1782848>, @jdoerfert wrote:

>   template <typename T> T __kmpc_impl_atomic_exchange(T *Ptr, T Val) {
>     return atomicExch(Ptr, Val);
>   }
>


OK, cool. So we still need the list of underlying functions from cuda.h or equivalent, and if the instantiation type isn't (implicitly convertible to one) on the list we get a slightly less readable compile time error. That seems like a good tradeoff. Agreed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71404/new/

https://reviews.llvm.org/D71404





More information about the Openmp-commits mailing list