[Openmp-commits] [PATCH] D71404: [libomptarget][nfc] Introduce atomic wrapper function

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Dec 12 15:09:09 PST 2019


JonChesterfield added a comment.

In D71404#1782271 <https://reviews.llvm.org/D71404#1782271>, @jdoerfert wrote:

> I think it is worth having this layer of abstraction. Aren't there other atmomics except add?


Yep. Complete list of functions used by the current deviceRTL is add, inc, max, exch, cas in a few integer variants. The others were left out for the (admittedly minor) reduction in work available from choosing a naming convention before the find&replace.

I think I'd also prefer to have the abstraction layer. It's part of viewing common/ as C++ plus well defined extensions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71404/new/

https://reviews.llvm.org/D71404





More information about the Openmp-commits mailing list