[Openmp-commits] [PATCH] D71412: [libomptarget][nfc] Add declarations of atomic functions for amdgcn

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked 3 inline comments as done.
JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h:8
+//===----------------------------------------------------------------------===//
+
+#include "target_impl.h"
----------------
jdoerfert wrote:
> Header guards should be useful here.
Agreed, sloppy to miss them out here. Fixed.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h:34
+                                    unsigned long long compare,
+                                    unsigned long long val);
----------------
jdoerfert wrote:
> One could have opted for a template solution but this is fine too.
This looks ugly in the header but has the attraction of mapping 1:1 onto functions defined in the support library, which may not want to implement them as explicit instantiations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71412/new/

https://reviews.llvm.org/D71412