[Openmp-commits] [PATCH] D66846: [libomptarget] Refactor macros from omptarget-nvptx to inline functions

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Aug 27 16:46:28 PDT 2019


JonChesterfield added a comment.

I'm not sure about the signal to noise of the C style `__kmpc_impl` namespace. Perhaps C++ `namespace __kmpc_impl {}` and `using namespace __kmpc_impl;` in the source would be better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66846/new/

https://reviews.llvm.org/D66846





More information about the Openmp-commits mailing list