[Openmp-commits] [PATCH] D65836: Factor architecture dependent code out of loop.cu

Tue Aug 13 12:06:18 PDT 2019

ABataev accepted this revision.
ABataev added a comment.

In D65836#1627635 <https://reviews.llvm.org/D65836#1627635>, @JonChesterfield wrote:

> > What about namong convention here? Shall we use capital letters for the var names or it is fine as is?
>
> Long term it's probably worth moving to the LLVM conventions throughout. Short term, I'd rather keep roughly the same style as the surrounding code. I believe that's what this patch does.
>
> > Also, did you come to an agreement about design, directory layout etc.?
>
> Overall agreement on the final design is a work in progress. I believe there is agreement that we'll need at least one target specific header, so this patch follows the suggestion in D64217 <https://reviews.llvm.org/D64217> and calls it target_impl.
>
> At the moment, nvptx/src is the most sensible directory for it (as that's the only directory!). I think this is an uncontentious step in the right direction.

Ok, LG

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65836/new/

https://reviews.llvm.org/D65836