[Openmp-commits] [PATCH] D65836: Factor architecture dependent code out of loop.cu

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D65836#1621112 <https://reviews.llvm.org/D65836#1621112>, @ABataev wrote:

> In D65836#1621104 <https://reviews.llvm.org/D65836#1621104>, @jdoerfert wrote:
>
> > @ABataev, others, any concerns? If not, let's go ahead with this.
>
>
> Did you come to an agreement about the design of the new universal library? I would suggest starting with this.


We have a proposal and no major complaints, I count that as agreement.

> We need to find a better way to files layout,

See above.

> design of the target-specific functions (template class with the specialization implementation for each particular target or just good old plain set of target-specific functions, controlled by the condition compilation), etc.

The design chosen here seems fine to me. Others didn't disagree. It is for sure a step in the right direction.

> Then, I would suggest committing this new structure at first.

I think extracting the code makes more sense first. Also mentioned in the proposal and not objected.
The problem is we cannot really restructure as it is still interleaved with target dependent code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65836/new/

https://reviews.llvm.org/D65836