[Openmp-commits] [PATCH] D64218: [OpenMP][NFCI] Cleanup the target synchronization implementation

Tue Aug 6 08:05:50 PDT 2019

jdoerfert added a comment.

In D64218#1616959 <https://reviews.llvm.org/D64218#1616959>, @ABataev wrote:

> In D64218#1616951 <https://reviews.llvm.org/D64218#1616951>, @jdoerfert wrote:
>
> > @ABataev I am confused by the comments you make. Could you describe a situation in which we do not execute the same code before and after this patch? Also, the O0/03 inline & constant propagation comment is not clear to me, what is the issue there?
>
>
> I was confused by the names of the template arguments.

I'm happy to rename them if we want to go ahead with this `__kmpc_impl_barrier` (potentially without the rest in here). Name suggestions are always welcome.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64218/new/

https://reviews.llvm.org/D64218