[Openmp-commits] [PATCH] D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: openmp/trunk/libomptarget/test/unified_shared_memory/shared_update.c:28-30
+  // Manual registration of requires flags for Clang versions
+  // that do not support requires.
+  __tgt_register_requires(8);
----------------
Apparently, this does not work: The generated code will call `__tgt_register_lib` first which caches the global `RequiresFlags` in `Device.RTLRequiresFlags`. Because `__tgt_register_requires` has not been called yet, the value is still 0 so the new code won't be executed. Please fix and test on your end that it works with older versions of the compiler!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65001/new/

https://reviews.llvm.org/D65001