[Openmp-commits] [PATCH] D65340: [OpenMP][libomptarget] Add support for close map modifier

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/test/unified_shared_memory/close_enter_exit.c:6
+
+// UNSUPPORTED: clang-3, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9
+
----------------
I think you can safely remove `clang-3` to `clang-5` because CMake will block tests with anything before `clang-6`.


================
Comment at: libomptarget/test/unified_shared_memory/close_manual.c:6
+
+// UNSUPPORTED: clang-3, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9
+
----------------
This completely misses the point: This test is supposed to work with older versions of clang, even those that don't support `close`.


================
Comment at: libomptarget/test/unified_shared_memory/close_manual.c:46-52
+// For the initalization of the device.
+#pragma omp target map(tofrom : device_alloc)
+  { device_alloc = 10; }
+
+  // CHECK: device_alloc updated on the device
+  if (device_alloc == 10)
+    printf("device_alloc updated on the device\n");
----------------
Why do we need this?


================
Comment at: libomptarget/test/unified_shared_memory/close_modifier.c:6
+
+// UNSUPPORTED: clang-3, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9
+
----------------
Same as above.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65340/new/

https://reviews.llvm.org/D65340