[Openmp-commits] [PATCH] D65885: Cleanup unused variable.

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov created this revision.
AndreyChurbanov added reviewers: jlpeyton, tlwilmar, Hahnfeld.
Herald added a reviewer: jdoerfert.
Herald added a project: OpenMP.
Herald added a subscriber: openmp-commits.

This patch fixes problem raised in post-review comments of the https://reviews.llvm.org/D65285.

Developers of ittnotify confirmed that dll_path_ptr field of the __itt_global structure is never used by ittnotify library, so it is safe to remove the dll_path array.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D65885

Files:
  runtime/src/thirdparty/ittnotify/ittnotify_static.cpp


Index: runtime/src/thirdparty/ittnotify/ittnotify_static.cpp
===================================================================
--- runtime/src/thirdparty/ittnotify/ittnotify_static.cpp
+++ runtime/src/thirdparty/ittnotify/ittnotify_static.cpp
@@ -226,8 +226,6 @@
 #pragma warning(pop)
 #endif /* ITT_PLATFORM==ITT_PLATFORM_WIN */
 
-static char dll_path[PATH_MAX] = { 0 };
-
 /* static part descriptor which handles. all notification api attributes. */
 __itt_global _N_(_ittapi_global) = {
     ITT_MAGIC,                                     /* identification info */
@@ -238,7 +236,7 @@
     MUTEX_INITIALIZER,                             /* mutex */
     NULL,                                          /* dynamic library handle */
     NULL,                                          /* error_handler */
-    (const char**)&dll_path,                       /* dll_path_ptr */
+    NULL,                                          /* dll_path_ptr */
     (__itt_api_info*)&api_list,                    /* api_list_ptr */
     NULL,                                          /* next __itt_global */
     NULL,                                          /* thread_list */


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65885.213897.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20190807/012ab08b/attachment.bin>