[Openmp-commits] [PATCH] D65340: [OpenMP][libomptarget] Add support for close map modifier

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.

The test will currently fail with older versions of Clang. It must at least be marked `UNSUPPORTED` for Clang versions older than what-will-be Clang 10.

Additionally, I'd still like to see a small test with manual calls to `__tgt_target_data_begin` / `_end` if possible. I'm thinking of the following:

  int *a = // malloc
  int *device;
  
  __tgt_target_data_begin(...); // with close modifier for a
  #pragma omp target data use_device_ptr(a)
  {
    device = a;
  }
  __tgt_target_data_end(...); // correspondingly to the begin call above
  
  // check...

Instead of the nested `target data` region, you could also use a simple `target` region in the outer data region, and have a check for `use_device_ptr` in another test.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65340/new/

https://reviews.llvm.org/D65340