[Openmp-commits] [PATCH] D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea marked 2 inline comments as done.
gtbercea added inline comments.


================
Comment at: libomptarget/src/device.cpp:174
+  if (RTLRequiresFlags & OMP_REQ_UNIFIED_SHARED_MEMORY &&
+      (IsImplicit || !lr.Flags.IsContained || Size)) {
+    DP("Return HstPtrBegin " DPxMOD " Size=%ld RefCount=%s\n",
----------------
gtbercea wrote:
> gtbercea wrote:
> > grokos wrote:
> > > I still don't understand this condition (even in the simplified form). Can you explain what we are testing?
> > The condition comes from the 1st and 3rd if conditions. I have updated the condition to its more explicit version.
> > 
> > But, from what I can tell, IsContained can never be true in this case, ExtendesBefore/After I think cannot be true either.
> > 
> > IsImplicit can vary, Size also.
> > 
> > So I would reduce the condition to:
> > 
> > (IsImplicit || Size)
> > 
> > Does this now make sense?
> > 
> > 
> Actually it should just be Size I think. Testing it now.
Condition has now been fixed. This is it in its simplest form.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65001/new/

https://reviews.llvm.org/D65001