[Openmp-commits] [PATCH] D65340: [OpenMP][libomptarget] Add support for close map modifier

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/src/omptarget.cpp:299-300
+          HasCloseModifier) {
+        if (IsNew || (arg_types[i] & OMP_TGT_MAPTYPE_ALWAYS) ||
+            HasCloseModifier) {
           copy = true;
----------------
gtbercea wrote:
> Hahnfeld wrote:
> > Hmm, thinking about this again: Does `close` imply `always`? I don't find this in the spec, so I think `HasCloseModifier` should not be in the inner condition.
> I think I see what you mean. The issue is not that this is in the innermost loop but that it may generate a copy to the device when IsNew is false. 
Yes, with "innermost condition" I meant the inner `if` statement, the one in the lines I marked.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65340/new/

https://reviews.llvm.org/D65340