[Openmp-commits] [PATCH] D52701: [libomptarget-nvptx] Enable asserts in bclib

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Sep 30 02:49:17 PDT 2018


Hahnfeld created this revision.
Hahnfeld added reviewers: gtbercea, grokos.
Herald added subscribers: openmp-commits, mgorny.

If the user requested LIBOMPTARGET_NVPTX_DEBUG, include asserts in
the bitcode library. Everything else will have very unpleasent
effects because asserts will appear when falling back to the static
library libomptarget-nvptx.a.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D52701

Files:
  libomptarget/deviceRTLs/nvptx/CMakeLists.txt


Index: libomptarget/deviceRTLs/nvptx/CMakeLists.txt
===================================================================
--- libomptarget/deviceRTLs/nvptx/CMakeLists.txt
+++ libomptarget/deviceRTLs/nvptx/CMakeLists.txt
@@ -124,7 +124,7 @@
     libomptarget_say("Building CUDA LLVM bitcode offloading device RTL.")
 
     # Set flags for LLVM Bitcode compilation.
-    set(bc_flags ${LIBOMPTARGET_NVPTX_SELECTED_CUDA_COMPILER_FLAGS} -DOMPTARGET_NVPTX_TEST=0)
+    set(bc_flags ${LIBOMPTARGET_NVPTX_SELECTED_CUDA_COMPILER_FLAGS})
     if(${LIBOMPTARGET_NVPTX_DEBUG})
       set(bc_flags ${bc_flags} -DOMPTARGET_NVPTX_DEBUG=-1)
     else()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52701.167640.patch
Type: text/x-patch
Size: 636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180930/2938f980/attachment.bin>


More information about the Openmp-commits mailing list