[Openmp-commits] [PATCH] D51235: [OpenMP] Change hint parameter type for critical to uint32_t.

Jonathan Peyton via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 7 11:47:53 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rOMP341694: [OpenMP] Change hint parameter type for critical to uint32_t (authored by jlpeyton, committed by ).

Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51235

Files:
  runtime/src/kmp.h
  runtime/src/kmp_csupport.cpp


Index: runtime/src/kmp.h
===================================================================
--- runtime/src/kmp.h
+++ runtime/src/kmp.h
@@ -207,6 +207,10 @@
       an invalid combination of hints to mean that another, larger field
       should be used in a different flag. */
   KMP_IDENT_ATOMIC_HINT_MASK = 0xFF0000,
+  KMP_IDENT_ATOMIC_HINT_UNCONTENDED = 0x010000,
+  KMP_IDENT_ATOMIC_HINT_CONTENDED = 0x020000,
+  KMP_IDENT_ATOMIC_HINT_NONSPECULATIVE = 0x040000,
+  KMP_IDENT_ATOMIC_HINT_SPECULATIVE = 0x080000,
 };
 
 /*!
@@ -3656,7 +3660,7 @@
 
 #if OMP_45_ENABLED
 KMP_EXPORT void __kmpc_critical_with_hint(ident_t *, kmp_int32 global_tid,
-                                          kmp_critical_name *, uintptr_t hint);
+                                          kmp_critical_name *, uint32_t hint);
 #endif
 
 KMP_EXPORT kmp_int32 __kmpc_barrier_master(ident_t *, kmp_int32 global_tid);
Index: runtime/src/kmp_csupport.cpp
===================================================================
--- runtime/src/kmp_csupport.cpp
+++ runtime/src/kmp_csupport.cpp
@@ -1351,7 +1351,7 @@
 speculative execution and the hardware supports it.
 */
 void __kmpc_critical_with_hint(ident_t *loc, kmp_int32 global_tid,
-                               kmp_critical_name *crit, uintptr_t hint) {
+                               kmp_critical_name *crit, uint32_t hint) {
   KMP_COUNT_BLOCK(OMP_CRITICAL);
   kmp_user_lock_p lck;
 #if OMPT_SUPPORT && OMPT_OPTIONAL


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51235.164484.patch
Type: text/x-patch
Size: 1456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180907/b761d2f4/attachment.bin>


More information about the Openmp-commits mailing list