[Openmp-commits] [PATCH] D51622: [libomptarget][NVPTX] Drop dead code and data structures, NFCI.

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld marked an inline comment as done.
Hahnfeld added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:24-42
-extern __device__ __shared__
-    omptarget_nvptx_ThreadPrivateContext *omptarget_nvptx_threadPrivateContext;
-
 extern __device__ omptarget_nvptx_Queue<
     omptarget_nvptx_SimpleThreadPrivateContext, OMP_STATE_COUNT>
     omptarget_nvptx_device_simpleState[MAX_SM];
 
----------------
ABataev wrote:
> Are you sure that you want to delete these variables?
Yes, they are also declared in `omptarget-nvptx.h` (I added an inline comment). I've been criticizing these duplicated declarations in a few reviews, time to get rid of them. Note that `omptarget_nvptx_device_State` and `omptarget_nvptx_device_simpleState` are not in the header because they are only used in this file.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:431-446
 extern __device__ __shared__
     omptarget_nvptx_ThreadPrivateContext *omptarget_nvptx_threadPrivateContext;
 extern __device__ __shared__ omptarget_nvptx_SimpleThreadPrivateContext
     *omptarget_nvptx_simpleThreadPrivateContext;
 
 extern __device__ __shared__ uint32_t execution_param;
 extern __device__ __shared__ void *ReductionScratchpadPtr;
----------------
Here.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51622