[Openmp-commits] [PATCH] D51222: [OPENMP][NVPTX] Lightweight runtime support for SPMD mode.

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: openmp/trunk/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:192-200
+  if (isRuntimeUninitialized()) {
+    if (threadId == 0) {
+      // Enqueue omp state object for use by another team.
+      int slot = smid() % MAX_SM;
+      omptarget_nvptx_device_simpleState[slot].Enqueue(
+          omptarget_nvptx_simpleThreadPrivateContext);
+      return;
----------------
ABataev wrote:
> Hahnfeld wrote:
> > ABataev wrote:
> > > Hahnfeld wrote:
> > > > Again looking at this code: Shouldn't all threads `return`, ie should it be outside of `if (threadId == 0)`?
> > > You're right, that was an original intention. Could commit a quick fix?
> > Yes please.
> I meant could you commit the fix? :) I don't have an access to my laptop. 
Ah, done in r341328. Thanks for your quick replies!


Repository:
  rL LLVM

https://reviews.llvm.org/D51222