[Openmp-commits] [PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records
Gheorghe-Teodor Bercea via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Oct 31 13:40:55 PDT 2018
gtbercea marked an inline comment as done.
gtbercea added inline comments.
================
Comment at: libomptarget/deviceRTLs/nvptx/src/supporti.h:191
PRINT(LD_MEM, "malloc data of size %zu for %s: 0x%llx\n", size, msg, P64(ptr));
- ASSERT(LT_SAFETY, ptr, "failed to allocate %zu bytes for %s\n", size, msg);
return ptr;
----------------
ABataev wrote:
> Same, do you really need to remove this?
Yes, leaving this in will lead to the whole malloc to be optimized out after inlining.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
More information about the Openmp-commits
mailing list